-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #16422 - Foreman API throws ruby exception with ovirt network API #4060
Conversation
Can an existing organization member please verify this patch? |
2 similar comments
Can an existing organization member please verify this patch? |
Can an existing organization member please verify this patch? |
@jkroepke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ShimShtein, @isratrade and @dLobatog to be potential reviewers. |
There were the following issues with the commit message:
If you don't have a ticket number, please create an issue in Redmine. More guidelines are available in Coding Standards or on the Foreman wiki. This message was auto-generated by Foreman's prprocessor |
@@ -321,7 +321,7 @@ def parent_resource_details | |||
parent_class | |||
end | |||
|
|||
return nil if parent_name.nil? | |||
return nil if parent_name.nil? or parent_class.nil? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use || instead of or.
There were the following issues with the commit message:
If you don't have a ticket number, please create an issue in Redmine. More guidelines are available in Coding Standards or on the Foreman wiki. This message was auto-generated by Foreman's prprocessor |
ok to test |
[test foreman] |
Passing a 'nil' resource_class to the |
See http://projects.theforeman.org/issues/16422#note-6